Write Column Logical Size Into Nimble Files #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 4, 2025
Summary: Rollback Plan: Differential Revision: D75973860
macvincent
force-pushed
the
export-D75973860
branch
from
5fa4cd8 to
bec583e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
force-pushed
the
export-D75973860
branch
from
bec583e to
2784a4f
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
macvincent
force-pushed
the
export-D75973860
branch
from
2784a4f to
6c87cec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
macvincent
force-pushed
the
export-D75973860
branch
from
6c87cec to
32c627b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
macvincent
force-pushed
the
export-D75973860
branch
from
32c627b to
55065db
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
macvincent
force-pushed
the
export-D75973860
branch
from
55065db to
c69745f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 6, 2025
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
macvincent
force-pushed
the
export-D75973860
branch
from
c69745f to
b55fc51
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 10, 2025
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
macvincent
force-pushed
the
export-D75973860
branch
from
b55fc51 to
9a55351
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
force-pushed
the
export-D75973860
branch
from
9a55351 to
6b42f10
Compare
macvincent
added a commit
to macvincent/nimble
that referenced
this pull request
Jun 10, 2025
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
Summary: Pull Request resolved: facebookincubator#176 Nimble file-level logical size is currently calculated using methods in the RawSizeUtils file. We can extend this util to also calculate column level logical size. This diff introduces support for this by calculating the logical size of the children in the top-level row of the Velox vector. We include unit testing for this change. Differential Revision: D75927903
Summary: Pull Request resolved: facebookincubator#177 Nimble file-level logical size is currently calculated using methods in the RawSizeUtils file. We can extend this util to also calculate column level null counts. This diff introduces support for this by calculating the null counts of the children in the top-level row of the Velox vector. We include unit testing for this change. Differential Revision: D75928862 Reviewed By: nathanphan26
Differential Revision: D76152908
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
Summary: Pull Request resolved: facebookincubator#179 Differential Revision: D75973860
|
This pull request was exported from Phabricator. Differential Revision: D75973860 |
macvincent
force-pushed
the
export-D75973860
branch
from
6b42f10 to
b8a39c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D75973860